search

words / powerthesaurus-api

Look up English synonyms, antonyms, etc with powerthesaurus.org
https://npm.im/powerthesaurus-api
MIT License
57 stars 5 forks source link

fix: update selector for scraping words #5

Closed zeke closed 4 years ago

zeke commented 4 years ago

Fixes #4 (maybe)

cc @wooorm @Michaelvons @rockroland

zeke commented 4 years ago

The build is failing because:

ERROR: Coverage for lines (94.59%) does not meet global threshold (100%)
ERROR: Coverage for functions (70%) does not meet global threshold (100%)
ERROR: Coverage for branches (90%) does not meet global threshold (100%)

But those are already failing on the master branch. @wooorm what would you suggest doing here?

wooorm commented 4 years ago

The parts and topics didn’t come through with that selector. I used the parent element instead, and that worked.

But, as they’re using some random css-in-js thing, it might change in the future 🤷‍♂️

zeke commented 4 years ago

Thanks for the fix, @woorm

$ np patch --no-2fa

Publish a new version of powerthesaurus-api (current: 2.0.2)

Commits:
- fix: update selector for scraping words (#5)  0df5ad7

Commit Range:
2.0.2...master

Registry:
https://registry.npmjs.org/

  ✔ Prerequisite check
  ✔ Git
  ✔ Cleanup
  ✔ Installing dependencies using npm
  ✔ Running tests using npm
  ✔ Bumping version using npm
  ✔ Publishing package using npm
  ✔ Pushing tags
  ✔ Creating release draft on GitHub

 powerthesaurus-api 2.0.3 published 🎉