workflow4metabolomics / tools-metabolomics

Galaxy tools for metabolomics maintained by Workflow4Metabolomics
https://workflow4metabolomics.org/
GNU General Public License v3.0
25 stars 27 forks source link

Inf in dataMatrix after fillPeaks #117

Closed sneumann closed 5 years ago

sneumann commented 6 years ago

Hi, @MarrSue and I are debugging a case where for one very specific parameter combination we get Inf values in the featureValues dataMatrix after fillPeaks. This was recently discussed in https://github.com/sneumann/xcms/issues/323#issuecomment-433044378 and should be fixed in newer XCMS versions. I had difficulties creating an R script that exactly replicates Sue's W4M history and exhibits the xcms bug locally, so I can't confirm the fix. Yours, Steffen

lecorguille commented 5 years ago

Should be fixed with: https://github.com/workflow4metabolomics/xcms/pull/119

lecorguille commented 5 years ago

Fix with: https://github.com/workflow4metabolomics/xcms/pull/120