world-federation-of-advertisers / cross-media-measurement

A privacy centric system for cross publisher, cross media ads measurement through secure multiparty computations.
https://halo.wfanet.org/
Apache License 2.0
36 stars 11 forks source link

ListMeasurements returns no results when timestamp filter bounds are not set #1893

Closed SanjayVas closed 2 weeks ago

SanjayVas commented 3 weeks ago

The issue appears to be that the internal request builder blindly copies the timestamp filters rather than first checking that they are indeed specified. This results in requests having e.g. both a created_before and created_after always set. If the public API request does not have the filter field specified, it will be copied as a default timestamp instance which effectively means "the beginning of the epoch". The only case where ListMeasurements would actually get a result is if all 4 timestamp filter field are specified.

Component(s) affected Kingdom

Version HEAD (latest: v0.5.12)