world-federation-of-advertisers / cross-media-measurement

A privacy centric system for cross publisher, cross media ads measurement through secure multiparty computations.
https://halo.wfanet.org/
Apache License 2.0
36 stars 11 forks source link

Simulator event groups created without event templates from --event-message-descriptor-set #1934

Open SanjayVas opened 5 days ago

SanjayVas commented 5 days ago

Reported by @nitamanna18

Describe the bug When the EDP simulator creates event groups using --event-message-descriptor-set to specify the event message descriptor, the event_templates field on those event groups is empty.

Steps to reproduce

  1. Configure the EDP simulator using --event-message-descriptor-set set to a FileDescriptorSet containing the descriptor for the UK Pilot Event message type and that type referenced by the population spec provided to --population-spec
  2. Run the simulator

Component(s) affected EDP simulator

Version v0.5.13

Environment Origin dev

Additional context

ListEventGroups response as JSON:

{
   "eventGroups": [
       {
           "name": "measurementConsumers/a1fyyNkb-TQ/eventGroups/KHrh5NWF6Fc",
           "cmmsEventGroup": "dataProviders/LkJlb3UZkY8/eventGroups/KHrh5NWF6Fc",
           "cmmsDataProvider": "dataProviders/LkJlb3UZkY8",
           "eventGroupReferenceId": "sim-eg-edp3ff",
           "eventTemplates": [],
           "metadata": {
               "fastflixId": "1234567890123456",
               "campaignEndDate": "07-12-2024",
               "displayName": "Fastflix Alpha Campaign",
               "brand": "SuperBrand",
               "campaignStartDate": "07-11-2024"
           }
       },
       {
           "name": "measurementConsumers/a1fyyNkb-TQ/eventGroups/N_DhhtWE2nw",
           "cmmsEventGroup": "dataProviders/TbsgjIrmbj0/eventGroups/N_DhhtWE2nw",
           "cmmsDataProvider": "dataProviders/TbsgjIrmbj0",
           "eventGroupReferenceId": "sim-eg-edp2tv",
           "eventTemplates": [],
           "metadata": {
               "campaignEndDate": "07-12-2024",
               "displayName": "Origin Alpha Campaign",
               "brand": "OriginBrand",
               "campaignStartDate": "07-11-2024"
           }
       },
       {
           "name": "measurementConsumers/a1fyyNkb-TQ/eventGroups/BFkdZ9WFOps",
           "cmmsEventGroup": "dataProviders/a0tmyormbgQ/eventGroups/BFkdZ9WFOps",
           "cmmsDataProvider": "dataProviders/a0tmyormbgQ",
           "eventGroupReferenceId": "sim-eg-edp1vb",
           "eventTemplates": [],
           "metadata": {
               "campaignEndDate": "07-12-2024",
               "displayName": "Vubox Alpha Campaign",
               "vuboxId": "9876543210987654",
               "brand": "Vubox",
               "campaignStartDate": "07-11-2024"
           }
       }
   ],
   "nextPageToken": null
 }

Population spec:

image

SanjayVas commented 5 days ago

My current theory is that the hasExtension check is incorrectly returning false due to not using the compiled-in event annotations descriptor.