search

wp-bootstrap / wp-bootstrap-navwalker

A custom WordPress nav walker class to fully implement the Twitter Bootstrap 4.0+ navigation style (v3-branch available for Bootstrap 3) in a custom theme using the WordPress built in menu manager.
https://wp-bootstrap.github.io/wp-bootstrap-navwalker/
GNU General Public License v3.0
3.37k stars 1.94k forks source link

Useless PHP unit tests for multisites? #511

Open IanDelMar opened 3 years ago

IanDelMar commented 3 years ago

The Travis contains a WP_MULTISITE=1 variable for both the matrix environment variables and the include environment variables. https://github.com/wp-bootstrap/wp-bootstrap-navwalker/blob/c856e941c4209581f8b90a31cc33350c758b3cfb/.travis.yml#L15-L17 https://github.com/wp-bootstrap/wp-bootstrap-navwalker/blob/c856e941c4209581f8b90a31cc33350c758b3cfb/.travis.yml#L28-L31 While the other variables, WP_VERSION and PHPUNIT_VERSION, are used, I don't see that WP_MULTISITE is used anywhere. https://github.com/wp-bootstrap/wp-bootstrap-navwalker/blob/c856e941c4209581f8b90a31cc33350c758b3cfb/.travis.yml#L65-L67

Additionally, the test file does not include any multisite tests. I think that all unit test with WP_MULTISITE=1 are duplicates of their WP_MULTISITE=0 versions and should be removed as they increase Travis build times and unnecessarily use Travis resources.