search

wp-bootstrap / wp-bootstrap-navwalker

A custom WordPress nav walker class to fully implement the Twitter Bootstrap 4.0+ navigation style (v3-branch available for Bootstrap 3) in a custom theme using the WordPress built in menu manager.
https://wp-bootstrap.github.io/wp-bootstrap-navwalker/
GNU General Public License v3.0
3.37k stars 1.94k forks source link

Remove aria-haspopup from dropdowns #526

Closed IanDelMar closed 3 years ago

IanDelMar commented 3 years ago

aria-haspopup="true" is really intended to signal that an ARIA menu will be opened on activation. as a result, some assistive technologies will announce controls with aria-haspopup="true" as a menu or menu item (e.g. JAWS and NVDA). In addition, aria-haspopup seems to trigger a bug in Edge/Narrator where the aria-expanded state is not correctly announced at the moment when aria-haspopup is present. This now makes the dropdown button more like a generic disclosure widget control - see also https://www.w3.org/TR/wai-aria-practices-1.2/examples/disclosure/disclosure-navigation.html01

See https://github.com/twbs/bootstrap/pull/33624#issue-857305617

Changes proposed in this Pull Request:

Proposed changelog entry for your changes:

Remove aria-haspopup from dropdowns