wp-cli / entity-command

Manage WordPress comments, menus, options, posts, sites, terms, and users.
MIT License
100 stars 90 forks source link

Extraneous warning message in wp user spam command #480

Closed ernilambar closed 8 months ago

ernilambar commented 8 months ago

Bug Report

Describe the current, buggy behavior

Example:

2 is existing user ID and 99999 is non-existing user ID. When I try following command:

wp user spam 2 99999

Output is:

Warning: Invalid user ID, email or login: '99999'
User 2 marked as spam.
Warning: User 99999 doesn't exist.
Error: Only spammed 1 of 2 users.

Two warnings for same user is redundant.

Describe what you would expect as the correct outcome

Only one warning is enough.

Let us know what environment you are running this on

OS:     Darwin 22.6.0 Darwin Kernel Version 22.6.0: Tue Nov  7 21:48:06 PST 2023; root:xnu-8796.141.3.702.9~2/RELEASE_X86_64 x86_64
Shell:  /bin/zsh
PHP binary:     /usr/local/Cellar/php@8.2/8.2.16/bin/php
PHP version:    8.2.16
php.ini used:   /usr/local/etc/php/8.2/php.ini
MySQL binary:   /usr/local/bin/mysql
MySQL version:  mysql  Ver 8.3.0 for macos13.6 on x86_64 (Homebrew)
SQL modes:
WP-CLI root dir:        phar://wp-cli.phar/vendor/wp-cli/wp-cli
WP-CLI vendor dir:      phar://wp-cli.phar/vendor
WP_CLI phar path:       /Users/nilambarsharma/Sites/bahu
WP-CLI packages dir:    /Users/nilambarsharma/.wp-cli/packages/
WP-CLI cache dir:       /Users/nilambarsharma/.wp-cli/cache
WP-CLI global config:
WP-CLI project config:  /Users/nilambarsharma/Sites/bahu/wp-cli.local.yml
WP-CLI version: 2.10.0
danielbachhuber commented 8 months ago

Makes sense, I agree 👍