CrochetFeve0251 commented 11 months ago

Description

This changes the query to filter first then make the join. This helps how fast the query is done.

Fixes #747

Type of change

New feature (non-breaking change which adds functionality).

Is the solution different from the one proposed during the grooming?

I added a regex instead of likes to optimize even more queries.

Checklists

Generic development checklist

[ ] My code follows the style guidelines of this project, with adapted comments and without new warnings.
[ ] I have added unit and integration tests that prove my fix is effective or that my feature works.
[ ] The CI passes locally with my changes (including unit tests, integration tests, linter).
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

[ ] I triggered all changed lines of code at least once without new errors/warnings/notices.
[ ] I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
[ ] I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

vmanthos commented 11 months ago

@CrochetFeve0251 With the PR, the queries are almost 5x faster! :rocket:

Please check the following:

None of the data is displayed in /wp-admin/upload.php?page=imagify-bulk-optimization.

The way it is with develop:

and with the PR:

imagify_has_attachments_without_required_metadata() was executed on /wp-admin/options-general.php?page=imagify with develop but not with the PR. Is this expected?

CrochetFeve0251 commented 11 months ago

@CrochetFeve0251 With the PR, the queries are almost 5x faster! 🚀

Please check the following:
1. None of the data is displayed in `/wp-admin/upload.php?page=imagify-bulk-optimization`.
The way it is with develop:

and with the PR:
2. `imagify_has_attachments_without_required_metadata()` was executed on `/wp-admin/options-general.php?page=imagify` with `develop` but not with the PR. Is this expected?

@vmanthos 2. is related to the SQL query which returned a different result not calling the query.

wp-media / imagify-plugin