CrochetFeve0251 commented 11 months ago

Description

Update the Chart.js dependency.

For that to make it clean I had to change the JS processor from grunt to bud.js.

Fixes #742

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

Yes cause I had to change from grunt to bud.js.

Checklists

Generic development checklist

[ ] My code follows the style guidelines of this project, with adapted comments and without new warnings.
[ ] I have added unit and integration tests that prove my fix is effective or that my feature works.
[ ] The CI passes locally with my changes (including unit tests, integration tests, linter).
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

[ ] I triggered all changed lines of code at least once without new errors/warnings/notices.
[ ] I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
[ ] I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

Mai-Saad commented 11 months ago

@CrochetFeve0251 Thanks for the PR. Kindly find exploratory test notes below 1- The thickness of the optimization chart > on the trunk so the 100 % won't fit @CrochetFeve0251 can you please check this Screenshot from 2023-10-31 12-12-02 2- Already on the trunk, refresh bulk optimization page while having 0 in the account will cause a warning. started discussion here => https://wp-media.slack.com/archives/CU0F6EGQ1/p1698744012970869 3- Already on the trunk, after the account balance is 0, we are still processing in the background. the progress bar and the number of errors will increase while the page of bulk optimization is in the background. screen-capture (59).webm

4- Already on the trunk, Sometimes, the optimized % decreased then increase again. shouldn't it either increase if more images are optimized or be fixed if the number of error increased

5-Already on trunk, on a website with large number of media. the % inside the chart doesn't update automatically and need manual refresh