Closed CrochetFeve0251 closed 10 months ago
We also have this PR related https://github.com/wp-media/imagify-plugin/pull/706
@CrochetFeve0251 Thanks for the update. Please find exploratory test notes below 1- The served image at the FE has size > the optimized size (for this image WebP isnot generated, however it's served, shouldn't we serve png in this case? even if the option to display WebP image on the website is enabled @wp-media/productimagify ) test page https://imagify.rocketlabsqa.ovh/test-webp/ 2- WebP generated is always no although it was generated (@wp-media/productimagify what shall be the text for convert when the image is converted to WebP? do we really need this field? /cc @MathieuLamiot ) on trunk
@Mai-Saad, thanks for the detailed report. About the 2nd point:
I do agree it seems a bit redundant with the message above saying WebP is not generated because it is bigger. It could be a small simplification, but let's see what @wp-media/productimagify thinks about this. We might not have all the cases in minds. In any case, that would be outside the scope of the issue..
@CrochetFeve0251 Thanks for the update. @MathieuLamiot Thanks for the feedback. Currently:
Specific image has no WebP generated while status is yes
An image which isnot converted, is served with a bigger size (tested on chrome ubuntu) (note: this image wasnot compressed somehow)
@CrochetFeve0251 Thanks for the update. Working as the following now. If agreed by @wp-media/productimagify then we can merge. /cc @MathieuLamiot
Webp is less performant than original
, WebP generated status is either No (if no webp file added to upload folder) or partial (if the webP file added to upload folder), image.extension is served on FE (as same as that in upload folder without extension nor dimensions and it is <= original size) if the serve webP option on/off2- Original image is webP
3- Already on trunk, origional/ optimized size is not matching that in the upload folder https://wp-media.slack.com/archives/CU0F6EGQ1/p1699598198861799
4- Already on trunk, while display image in webp isnot checked, the used size at FE is that of webp but without adding webp extension https://wp-media.slack.com/archives/CU0F6EGQ1/p1699618969452739
Looks good. The only change is on the wording to make it clearer about why the origin image will be served instead:
Change:
Webp is less performant than original
To:
WebP file is larger than the original image
Description
Fixes #2554
Display the message when we display a original format instead of the webp one.
Type of change
Please delete options that are not relevant.
Is the solution different from the one proposed during the grooming?
No.
Checklists
Generic development checklist
Test summary
If not, detail what you could not test.
Please describe any additional tests you performed.