search

wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.
https://imagify.io
71 stars 25 forks source link

Upgrade PHP Unit version #770

Open Miraeld opened 8 months ago

Miraeld commented 8 months ago

Is your feature request related to a problem? Please describe. It is not possible to run composer install while being on a PHP >= 8.0 as the PHPUnit rule we have in the composer.json requires a version <= PHP 7.4.

Describe the solution you'd like It would be nice to upgrade these version to keep up to date with php versions.

Describe alternatives you've considered Change these: 

"phpunit/phpunit": "^7.5",
"wp-media/phpunit": "2.0"

to

"phpunit/phpunit": "^7.5 || ^8 || ^9",
"wp-media/phpunit": "^3"
Miraeld commented 8 months ago

Scope a solution

To implement this feature, we must change the version within the composer.json file. Also we shouldn't forget to trigger all tests to make sure everything works fine with the new version.

Development steps:

Effort estimation:

S

Can be peer-coded:

No

Is a refactor needed in that part of the codebase?

No

jeawhanlee commented 8 months ago

Looks good to me...