wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.
https://imagify.io
71 stars 25 forks source link

Change methods name #785

Closed Khadreal closed 8 months ago

Khadreal commented 8 months ago

Description

Changed methods name for media library view

Fixes #779

Type of change

Is the solution different from the one proposed during the grooming?

No

Please describe in this section if there is any change to the groomed solution, and why.

Checklists

Generic development checklist

Test summary

Khadreal commented 8 months ago

@Miraeld I think I should assigned this https://github.com/wp-media/imagify-plugin/issues/779 to you, it seems you've already worked on it and https://github.com/wp-media/imagify-plugin/issues/778 by looking at your commits history

Miraeld commented 8 months ago

There is no need to re-assign it I think. From what I've seen on other PRs, we've been using next_gen notation instead of nextgen. As I needed few of these functions in an other PR, I had to rename them. I made my comment here to avoid either of us having conflicts.

Tabrisrp commented 8 months ago

This PR needs conflict fixed before moving forward

Khadreal commented 8 months ago

While resolving the conflicts I noticed that the issue #779 was created based on develop branch and deature/avif branch has few things that aren't captured in the issue. Is it safe to rename all next_gen to nextgen ? @Tabrisrp