Closed diegoavalon closed 2 weeks ago
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. Learn more about preview environments in our documentation.
Latest commit: 9fc2596ce3be9da9b3bc21230f87f528b0eb8ab9
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Hey @diegoavalon. Can you add glob-promise
in package.json dev dependency as well please?
hi @theodesp , glob-promise
isn't being used in this package anymore and has been removed.
@diegoavalon Could you also create a Changeset as well please? The instructions are mentioned in the changeset-bot
npm run changeset
Hi @theodesp , my apologies, I see what I did wrong. After creating the changeset for this change I manually executed npm changeset version
locally which bumped the affected package versions and deleted the generated changeset.md file. Instead, this should have been a CI step. Hopefully, this PR is now as expected. Can you kindly validate?
Hey @diegoavalon thank you. Could you restore this file please? https://github.com/wpengine/faustjs/pull/1967/files#diff-acbd6f841eb36512210b996294dcd4050a5febdb1fa023bb30c962f6c2707314
This is the changeset for another PR and it should be part of the folder as well.
hi @theodesp , can you kindly review this new PR cut from a clean branch and commit history of these changes? PR #1966
Hey @diegoavalon . This PR that we merged yesterday contains this update so we can close this now. Thanks.
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. Learn more about preview environments in our documentation.
!IMPORTANT
Glob has native Promise support as of v9.0.0, please use it directly. I will not issue a deprecation notice on this package, because I can't deal with the volume of angry tickets that will follow.