search

wpengine / github-action-wpe-site-deploy

A GitHub Action to deploy code directly to WP Engine.
MIT License
173 stars 36 forks source link

Update Readme with working exclude example and ensure exclude.txt doesn't delete wpe-cache-plugin #19

Closed mgratch closed 2 years ago

mgratch commented 2 years ago

JIRA Ticket

Sorry no ticket just a helpful bystander.

What Are We Doing Here

The purpose of this PR is to address 2 issues:

  1. The new README documentation provides a working example to exclude deleting two files and a directory. The existing example is not helpful as it includes quote marks and appears to intend to exclude everything? After thorough testing, troubleshooting, and reaching out to support -- I was able to determine that quote marks are not actually supported.
  2. The current exclude.txt wasn't actually excluding the wpe-cache-plugin, both the directory and the php file were being deleted. The included update appears to fix this issue.