search

wpilibsuite / 2025Beta

Repository for Beta Testing of 2025 Software
15 stars 5 forks source link

REV Hardware Client crashes when connecting to USB devices #31

Open jwbonner opened 2 weeks ago

jwbonner commented 2 weeks ago

When connecting over USB to a Spark Max, Spark Flex, or PDH, the main window of the hardware client closes with no error message. The window also closes immediately when reopening the application with a USB device connected.

This seems to occur regardless of device firmware version (tested with 2023 through 2025 beta), and I've recreated it on ~5 laptops running both Windows 10 and 11. It's possible to update firmware by placing devices in recovery mode, but the hardware client crashes again upon reconnecting to the flashed device (meaning that it cannot be configured).

The main process appears to continue running when the window closes, but I don't see any error messages for the main process or renderer process when enabling logging for Electron (just the normal status messages about checking for updates, etc).

Tested on hardware client version 2025 beta 0 and alpha 7.

NoahAndrews commented 2 weeks ago

We don't see this issue, so I'm discussing this with @jwbonner directly. It would be helpful to know if anyone else is running into this issue as well.

Kevin-OConnor commented 2 weeks ago

I don't see this issue but did see the other reported issue of not being able to set any parameters using HW Client with the Beta HW client and Beta firmware installed.

GrahamSH-LLK commented 2 weeks ago

I believe I also ran into this or a similar issue when connecting/disconnecting USB devices, although the app would sometimes reopen. It was certainly not every time I connected or disconnected a device, though.

NoahAndrews commented 1 week ago

It appears this was caused by an outdated Visual C++ Redistributable. It'll be fixed in the next REV Hardware Client beta release.

@GrahamSH-LLK I'm pretty confident what you saw was a different issue. If you see it again, please report an issue through the small link in the bottom-right corner of the REV Hardware Client, and let me know that you've done so.

GrahamSH-LLK commented 1 week ago

It appears this was caused by an outdated Visual C++ Redistributable. It'll be fixed in the next REV Hardware Client beta release.

@GrahamSH-LLK I'm pretty confident what you saw was a different issue. If you see it again, please report an issue through the small link in the bottom-right corner of the REV Hardware Client, and let me know that you've done so.

I couldn't reproduce at all today, so I think it's probably safe to close for now. It did restart sometimes after unplugging USB, but that had a toast that said "Couldn't verify motors stopped, restarting" so that seems like intentional behavior

NoahAndrews commented 1 week ago

Ok, I'll close this after we release the next RHC beta.

srimanachanta commented 4 days ago

It would be helpful to know if anyone else is running into this issue as well.

My team is also running into this problem on REV Hardware Client 1.6.7-frcBeta2025.0. We can test out a new version of the hardware client when it is released and see if the issue is resolved.

NoahAndrews commented 3 days ago

It would be helpful to know if anyone else is running into this issue as well.

My team is also running into this problem on REV Hardware Client 1.6.7-frcBeta2025.0. We can test out a new version of the hardware client when it is released and see if the issue is resolved.

@srimanachanta In the meantime, you can fix the issue by installing the latest Visual C++ Redistributable: https://aka.ms/vs/17/release/vc_redist.x64.exe