search

wpsharks / phings

Just a few Phings we like to use :-)
GNU General Public License v3.0
1 stars 0 forks source link

phing release-rc uploads generic zip filename to GitHub Release #112

Open raamdev opened 8 years ago

raamdev commented 8 years ago

The filename that gets included on the GitHub Release by the phing release-rc command is a generic comment-mail.zip filename, as opposed to something that includes the version number (e.g., comment-mail-v160611-RC.zip):

2016-06-10_22-15-57

Including the version number in the filename would be very helpful to avoid confusion (when somebody downloads the zip file, they'll be able to see what version of Comment Mail is included in that zip file).

jaswrks commented 8 years ago

Noting that the next release of the hub tool will make this easier so I'm going to wait for a bit and see if that is made available soon. Referencing: https://github.com/github/hub/blob/master/commands/release.go#L63

jaswrks commented 8 years ago

Noting that 'hub' v2.2.5 is now available and it includes the changes we need to implement this properly. However, the Homebrew package has not been updated just yet, so still waiting on that.

jaswrks commented 8 years ago

Noting that the Homebrew package has been updated. This is now 'ready for work'.

All Team Members Should Run

$ brew update;
$ brew upgrade hub;
jaswrks commented 7 years ago

Noting that I attempted to implement this, but as of Hub v2.2.9 this does not appear to work as documented. Leaving this as-is for now.

raamdev commented 7 years ago

@jaswsinc Noting that you still have a changelog entry in https://github.com/websharks/phings/blob/dev/CHANGELOG.md that indicates we're using named uploads, even though that change has been reversed.

jaswrks commented 7 years ago

Thank you for catching that.

jaswrks commented 7 years ago

A maintainer tells me this is currently available only in the master branch. Which is their dev branch: https://github.com/github/hub

jaswrks commented 7 years ago

Flagging this as blocked. Awaiting next major release of Hub. See previous comment.