search

wpsharks / s2member

s2Member® Framework (membership management for WordPress®).
64 stars 36 forks source link

Use of deprecated function #1181

Open Beee4life opened 4 years ago

Beee4life commented 4 years ago

EXPLANATION OF THE ISSUE

Function create_function() is deprecated in /var/www/html/web/app/plugins/s2member-pro/pro-module.php on line 135

It's also used on lines 127, 131 and 140.

STEPS TO REPRODUCE THE ISSUE

Install S2Member + Pro

BEHAVIOR THAT I EXPECTED

That I won't get any logs in my error log.

BEHAVIOR THAT I OBSERVED

See explanation of issue.

Beee4life commented 4 years ago

I see an updated version was just released... missed that... will check that first.

Beee4life commented 4 years ago

Just did a recheck... create_function is still used. This function is deprecated as of PHP 7.2, see official docs here.

It's also used in s2member/s2member.php on lines 177 and 181.

clavaque commented 4 years ago

Thanks @Beee4life !

That will be in the next release. :)

https://github.com/wpsharks/s2member/commit/05ff4ae6fd30ecaf4c3d606bfc430e9a1fd45c2d

https://github.com/wpsharks/s2member-pro/commit/f0b9d4ef420362ed33b5b4b192c75e4b941475cd

Beee4life commented 3 years ago

When does this release come ? The last version is dated March 1.