Fix the null pointer in operations json list.

Malith-19 commented 4 months ago

Purpose

Fix https://github.com/wso2/product-is/issues/19409

This issue occures, when a invalid operation schema field given since it only acceptsOperations` field. Once json schema not contains this filed correctly it will create a null pointer and raise an error in a for loop used to iterate that operation list.

Goals

Handle the internal error in PATCH scim2/v2/roles/{id} API.

Approach

Check weather operation list is null first.
If yes, then it checks json schema contains operations field and throws an bad request error error with invalid json schema.
If operation list is null and still not has operations throws an bad request error with default error description.

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

CLAassistant commented 4 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Malith-19 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

jenkins-is-staging commented 4 months ago

PR builder started Link: https://github.com/wso2/product-is/actions/runs/9723735849

jenkins-is-staging commented 4 months ago

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/9723735849 Status: success

wso2 / charon