search

wso2 / product-is

Welcome to the WSO2 Identity Server source code! For info on working with the WSO2 Identity Server repository and contributing code, click the link below.
http://wso2.github.io/
Apache License 2.0
765 stars 747 forks source link

Hide Delete Button for Shared Users with Type SHARED or OWNER #23088

Closed BimsaraBodaragama closed 1 month ago

BimsaraBodaragama commented 1 month ago

Current Limitation

Currently, the delete button is displayed for all users in the UI, regardless of whether they are shared or not, and if shared, irrespective of the shared type. However, with the introduction of [#22331(https://github.com/wso2/product-is/issues/22331)] feature, deletion is restricted [#442(https://github.com/wso2-extensions/identity-organization-management/pull/442)] for users whose shared type is SHARED or OWNER. According to the updated logic, only the following users should be deletable:

Since the UI does not reflect these restrictions, users may attempt to delete shared users, leading to errors, confusion, and a poor user experience.

Suggested Improvement

Update the UI to hide the delete button for users whose shared type is either SHARED or OWNER. The delete button should only be visible when deletion is permitted, ensuring consistency between the frontend and backend behavior.

Version

7.1.0-beta

BimsaraBodaragama commented 1 month ago

You can track the PR here.