Pass exception to within_sidekiq_retries_exhausted_block

wspurgin / rspec-sidekiq

RSpec for Sidekiq

https://github.com/wspurgin/rspec-sidekiq

Other

662 stars 133 forks source link

Pass exception to within_sidekiq_retries_exhausted_block #100

Closed packrat386 closed 8 years ago

packrat386 commented 8 years ago

Currently this method doesn't allow for sending an exception, but sidekiq will send it along with the block.

https://github.com/mperham/sidekiq/blob/35a7962093040784b48498e012bdff380ef991a8/lib/sidekiq/middleware/server/retry_jobs.rb#L143

coveralls commented 8 years ago

Coverage decreased (-40.4%) to 53.746% when pulling 0481b690a69c35b33f4b420b36c458dd4fc32e99 on packrat386:add_exception into 70d024c64ae2326a3b1a8c286b247a66f40ed2a9 on philostler:develop.

coveralls commented 8 years ago

Coverage decreased (-40.4%) to 53.746% when pulling 0481b690a69c35b33f4b420b36c458dd4fc32e99 on packrat386:add_exception into 70d024c64ae2326a3b1a8c286b247a66f40ed2a9 on philostler:develop.

coveralls commented 8 years ago

Coverage decreased (-40.4%) to 53.746% when pulling 0481b690a69c35b33f4b420b36c458dd4fc32e99 on packrat386:add_exception into 70d024c64ae2326a3b1a8c286b247a66f40ed2a9 on philostler:develop.

packrat386 commented 8 years ago

Can't really figure out why every single test is failing. I'm getting the same error when I try to run the tests on master.

packrat386 commented 8 years ago

These failures are fixed by #101. I'll rebase when that gets merged.

philostler commented 8 years ago

Cheers @packrat386

philostler commented 8 years ago

@packrat386 Couple of test failures appeared after merge. Mind rebasing and a taking a look?

packrat386 commented 8 years ago

sure

packrat386 commented 8 years ago

@philostler #103 should fix that.