search

wspurgin / rspec-sidekiq

RSpec for Sidekiq
https://github.com/wspurgin/rspec-sidekiq
Other
663 stars 132 forks source link

Does this gem need a new owner? #186

Closed adsteel closed 1 year ago

adsteel commented 2 years ago

I'm not seeing any activity on this gem in the past 2 years, but there are a number of apparently valid, open issues and PRs. I work at Stitch Fix and we use this gem heavily. Personally I love it, it makes my life easier and I'd love to see it continue to grow. I'd be interested in taking over ownership/maintenance if that's an option.

bmulholland commented 2 years ago

Given there's no response, I'd say just fork it and start pulling in PRs :)

hirowatari commented 1 year ago

Please let us know if you decide to do something with this. It would be wonderful to have Stich Fix maintain this.

philostler commented 1 year ago

Hi! Yeah I don't spend any time in the Ruby world anymore and if there are active users of this gem I'd happily hand it over to anyone that wants to take on it's future maintenance and development. @adsteel Would you prefer being added to the contributors or I believe it's possible to transfer ownership of the repo. From memory I'd have to give push access to Ruby gems as well (been a while since I did anything on this space)

adsteel commented 1 year ago

@philostler I spoke too soon about taking this on on behalf of Stitch Fix, but I'm still interested on a personal level. I reached out on LinkedIn, since your contact info here looks like it might be outdated.

adsteel commented 1 year ago

Hm, thought I left a comment yesterday, but guess I didn't "send."

@philostler Seems like Linkedin isn't working for communication either. I'd love to be made a contributor, or even take ownership if you'd rather. I've taken this week to poke around and I'd love to help keep this gem alive if I could. If I make decent progress on my own I'll consider publishing a new version under a new name, but I'd love to use this repo if possible.

@packrat386. I see you're a contributor (at least) and a rubygems owner, any chance you're able to give me some permissions here?

wspurgin commented 1 year ago

Hi 👋 Fellow interested party in ownership and maintenance. I worked with @adsteel at Stitch Fix too. Happy to be a collaborator/maintainer/co-owner. This gem makes life much easier, and I want to see several of the open PRs/issues continue to make it useful for the Sidekiqs out here ❤️

packrat386 commented 1 year ago

So, I can't transfer ownership of this repository because I don't have admin privileges on it. I can however merge PRs and release new versions to rubygems.

I've been reluctant to take on requests for new features/releases because I no longer use the gem myself. But @adsteel if you're willing to put in the time reviewing and approving PRs you can ping me when you're ready to have one merged. Similarly if you collate features into a new release version I'm happy enough to push it to rubygems on request. Bit of an awkward workaround for now, but could be workable in the short term?

adsteel commented 1 year ago

Unfortunately, I've since left Stitch Fix and am not currently working in Ruby. So I'd suggest you take up @wspurgin 's offer.

@wspurgin here's work I did to bring rspec-sidekiq up to date with Ruby 3.2, and get a new build working on GitHub actions. You're welcome to use any, all or none of it.

wspurgin commented 1 year ago

Always a pleasure Adam :heart:

packrat386 commented 1 year ago

@wspurgin I can extend you the same deal then. If you want to take up the mantle just let me know when you want something merged or released?

wspurgin commented 1 year ago

@packrat386 That sounds like a reasonable plan for now. Until @philostler transfers ownership (you can also manage owners via the RubyGems UI which might be easier)

wspurgin commented 1 year ago

@philostler at your earliest convenience could you:

  1. Transfer ownership to me (wspurgin), I'm happy to have the repo. Or at least give me "Maintainer" privileges if you want to keep the repo so I have full access for moderation/management
  2. Make me the owner or grant push access on RubyGems to rspec-sidekiq - I'm wspur on RubyGems https://rubygems.org/profiles/wspur

Cheers! 🎉

packrat386 commented 1 year ago

I can add you as an owner on rubygems. I've sent an invite for that.

I can't give you repo access though unfortunately.

philostler commented 1 year ago

HI @wspurgin. I couldn't transfer you ownship. GitHub threw me this error when I tried...

wspurgin already has a repository in the philostler/rspec-sidekiq network

I have however just added you to the Collaborator list.

wspurgin commented 1 year ago

Hey @philostler! Thanks so much! That error is from the fact that I had a fork still. Could you try again? I just deleted it.

philostler commented 1 year ago

@wspurgin Transfer request done. I don't touch Ruby anymore now so I'm glad this project is moving on to those that have time to move it forward. Good luck!

P.s. Thanks @wspurgin for taking this on, and @packrat386 for your contributions up to now.

wspurgin commented 1 year ago

Thank you @philostler! Transfer complete. We wouldn't be here without your fine work to start with 🚀

+1 to @packrat386 for all the contributions and helping us out here during the transition.

p.p.s., You may quit Ruby, but Ruby doesn't quit you! 😉