Fix clash with rspec-rails

wspurgin / rspec-sidekiq

RSpec for Sidekiq

https://github.com/wspurgin/rspec-sidekiq

Other

662 stars 133 forks source link

Fix clash with rspec-rails #95

Closed pavel-jurasek closed 8 years ago

pavel-jurasek commented 8 years ago

This PR fix clash with rspec-rails

coveralls commented 8 years ago

Coverage decreased (-0.8%) to 95.971% when pulling 214d5d5eed07ff777f3d5d3d66d2b283c0bc928b on pavel-jurasek-bcgdv-com:develop into e9f2256f780a50d1d593f36c6c91c96fce6d5aa6 on philostler:develop.

coveralls commented 8 years ago

Coverage decreased (-0.8%) to 96.0% when pulling c023ad71749d05852252f0b327b02b7b1e11a08d on pavel-jurasek-bcgdv-com:develop into e9f2256f780a50d1d593f36c6c91c96fce6d5aa6 on philostler:develop.

philostler commented 8 years ago

Hi @pavel-jurasek-bcgdv-com , is this in addition to #84 or an improved version of?

pavel-jurasek commented 8 years ago

@philostler improved version

pavel-jurasek commented 8 years ago

Add ability to match symbols
Fix matcher with combination with ActiveJob

philostler commented 8 years ago

Thanks @pavel-jurasek-bcgdv-com . Merged!

bk-one commented 8 years ago

Can we get a backport of that in rspec-sidekiq 2.x? Or is 3.0 coming in the foreseeable future? Happy to provide a patch

bk-one commented 8 years ago

https://github.com/philostler/rspec-sidekiq/pull/108