search

wstrange / asn1lib

Dart ASN1 Encoder / Decoder
BSD 2-Clause "Simplified" License
30 stars 30 forks source link

Improve length computing by using ASN1Length class #36

Closed Ephenodrom closed 4 years ago

Ephenodrom commented 4 years ago

Hello,

while parsing a certificate and trying to create a sha1 thumbprint of the public key, i found out that the length computing was wrong. The length computing did not consider valuebytes with big length. Therefore i changed the computing by using the corresponding static method from the ASN1Length class.

I checked all unit tests and added 2 new tests.

Regards

wstrange commented 4 years ago

Nice!
Can you bump the pubspec version, and create a CHANGELOG entry- then I will push a new version to pub

Ephenodrom commented 4 years ago

@wstrange I updated the pubspec file and added a changelog entry.

Regards

wstrange commented 4 years ago

Thanks so much for the PR. I'll get this updated in pub ASAP