improve length computing for ASN1Sequences

wstrange / asn1lib

Dart ASN1 Encoder / Decoder

BSD 2-Clause "Simplified" License

30 stars 31 forks source link

improve length computing for ASN1Sequences #37

Closed Ephenodrom closed 5 years ago

Ephenodrom commented 5 years ago

Hello,

I have some improvement for the length computing. There was a problem with the computing especially for ASN1Sequences.

Changes :

Fix in the ASN1Parser
Added a special unit test for this in the ans1_parser_test.dart file
Fixed some linter problems in the README.md and CHANGELOG.md

I already updated the pubspec.yaml and the CHANGELOG.md.

Unit tests :

pub run test 00:06 +48: All tests passed!

Regards

wstrange commented 5 years ago

Thanks Daniel. I can look into giving you commit access to this repo and pub. Let me know if you want to purse that.

Ephenodrom commented 5 years ago

@wstrange Yeah would be great. I think i will add some more commits in the future. Currently working on a small Flutter app that is based on this package.