wtclarke / pymapvbvd

Python port of mapVBVD
MIT License
40 stars 25 forks source link

Unnecessary dependencies in install_requires #29

Closed musicinmybrain closed 1 year ago

musicinmybrain commented 1 year ago

A couple of the dependencies that setup.py reads from requirements.yml to form the install_requires do not really need to be runtime dependencies.

I don’t know much about the requirements.yml file, and every Python project seems to handle this differently, but would it be possible to move these out into separate requirements.txt style files, or add a test extra, so that installing the package doesn’t bring in pytest in particular?

wtclarke commented 1 year ago

Hi @musicinmybrain,

Yes, I wasn't very experienced with python packaging when I pulled this together. The setuptools dependency is now handled in the pyproject.toml file, and I'll take a look at how to do the tests dependency. The extras look like a good mechanism.

wtclarke commented 1 year ago

This should be sorted in 0.5.3

musicinmybrain commented 1 year ago

Thanks!