search

wtclarke / spec2nii

Multi-format in vivo MR spectroscopy conversion to NIFTI
Other
27 stars 23 forks source link

Update to definitions.py #58

Closed markmikkelsen closed 1 year ago

markmikkelsen commented 1 year ago
wtclarke commented 1 year ago

Hi @markmikkelsen I've actually just moved this bit to a new package focussing on NIfTI-MRS validation/manipulation tools which spec2nii will load. See https://github.com/wtclarke/nifti_mrs_tools. I'll transfer these changes over to the appropriate file in the next version, which will be released once it's accepted by conda-forge.

markmikkelsen commented 1 year ago

Sounds good. I have made some edits to spec2nii to convert GE data. Should I make a pull request to spec2nii or nifti_mrs_tools? I'm guessing the former.

wtclarke commented 1 year ago

The former will be more appropriate.

From: Mark Mikkelsen @.> Date: Friday, 13 January 2023 at 15:04 To: wtclarke/spec2nii @.> Cc: William Clarke @.>, Comment @.> Subject: Re: [wtclarke/spec2nii] Update to definitions.py (PR #58)

Sounds good. I have made some edits to spec2nii to convert GE data. Should I make a pull request to spec2nii or nifti_mrs_tools? I'm guessing the former.

— Reply to this email directly, view it on GitHubhttps://github.com/wtclarke/spec2nii/pull/58#issuecomment-1381988630, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJJTTTTXBV4KQ26S6FLILLWSFVFRANCNFSM6AAAAAATZ5UF44. You are receiving this because you commented.Message ID: @.***>

wtclarke commented 1 year ago

These updates have been applied to the standard and appear in V0.7. In turn, V0.1.3 of the nifti-mrs python package will incorporate V0.7 definitions. The next version of spec2nii will use the nifti-mrs definitions.