search

wtclarke / spec2nii

Multi-format in vivo MR spectroscopy conversion to NIFTI
Other
27 stars 23 forks source link

f-strings everywhere #94

Closed DimitriPapadopoulos closed 1 year ago

wtclarke commented 1 year ago

Hi thanks for your continued interest in spec2nii. I'm closing this PR as it is purely cosmetic, and whilst I agree that fstrings are nicer to read in the long-run, I have no desire to create unnecessary code changes. In general, changes can introduce subtle bugs and also complicates using tools like git blame.

DimitriPapadopoulos commented 1 year ago

I understand. In this specific case, the rationale was that f-strings are faster, not only more readable.

DimitriPapadopoulos commented 1 year ago

As for git blame, there's option --ignore-revs-file (together with a file named .git-blame-ignore-revs by convention). But I understand that since there's no way to have that file taken into account by default, you won't like the idea.