signed int extract and construct functions implementation

[GoogleCodeExporter]

Patch against rev. 186

- solve a small bug in 64 bits platforms (mask created was not always 31
bits wide)

- implemented needed functions in order to use signed qualifier with ints
(2..31 bits only)

Original issue reported on code.google.com by matthieu...@gmail.com on 25 Mar 2010 at 2:43

Attachments:

• signed_int.patch

[GoogleCodeExporter]

I add some brute force tests

Original comment by matthieu...@gmail.com on 25 Mar 2010 at 2:45

Attachments:

• signed_int_tests.patch

[GoogleCodeExporter]

Hello,

I'm trying to read 32 bit signed int but its not yet implemented. Is it 
possible to get a patch for that?

Original comment by josephel...@gmail.com on 23 May 2012 at 12:10

[GoogleCodeExporter]

Would this be correct?

let extract_int32_le_signed = 
  extract_and_extend_sign extract_int32_le_unsigned

Original comment by josephel...@gmail.com on 23 May 2012 at 12:15

[GoogleCodeExporter]

It's certainly possible to *write* a patch for it.  I don't have time right 
now.  It should be pretty trivial to do, but you'll have to dig into the source.

Original comment by richard....@gmail.com on 23 May 2012 at 12:51

[GoogleCodeExporter]

Sorry, since there's a patch attached, why not try that out?

Original comment by richard....@gmail.com on 23 May 2012 at 12:52

[GoogleCodeExporter]

That's exactly what I'm doing.. Thanks anyway

Original comment by josephel...@gmail.com on 23 May 2012 at 1:04

[GoogleCodeExporter]

Hello Richard,

is there any problem with the patch proposed? I would adapt it if it could help 
you to integrate this modification.

Thanks

Original comment by matthieu...@gmail.com on 30 Jul 2014 at 6:43

[GoogleCodeExporter]

No, there was no problem.  I have pushed your commit (r202).

Original comment by richard....@gmail.com on 30 Jul 2014 at 7:40

• Changed state: Fixed

[GoogleCodeExporter]

Nice!

I thank you.

Le 30/07/2014 21:40, bitstring@googlecode.com a �crit :

Original comment by matthieu...@gmail.com on 31 Jul 2014 at 11:21