search

wttech / AEM-Rules-for-SonarQube

SonarQube plugin with set of rules detecting possible bugs and bad smells specific for AEM development.
Apache License 2.0
112 stars 50 forks source link

Make "AEM-Rules-for-SonarQube" compatible with SonarQube 10.4 "DownloadOnlyWhenRequired" feature #240

Open agigleux opened 6 months ago

agigleux commented 6 months ago

Hello,

I'm Alex, Product Manager at Sonar.

SonarQube 10.4 will come with a feature to only download Sonar analyzers and 3rd-party plugins when they are really required by the Scanner. To make this feature work, each analyzer or 3rd-party plugin should declare the list of languages on which they expect to raise issues through a new MANIFEST property called Plugin-RequiredForLanguages.

See https://community.sonarsource.com/t/the-sonarscanners-download-only-required-3rd-party-plugins/108156 for more details.

Regards

dbrin commented 1 month ago

This is now unfortunately blocking our 10.x upgrade

tomasz-niedzwiedz-wttech commented 1 month ago

Hi @agigleux, I think I misunderstood the semantics of the newly introduced property and thought this plugin wouldn't be affected. We're not using the plugin these days so it never came up as an issue internally.

What needs to be done is an upgrade of the sonar-packaging-maven-plugin, followed by the declaration of java and html in the requiredForLanguages config, due to dependencies on the Sonar Java plugin and the Sonar HTML plugin.

I've opened https://github.com/wttech/AEM-Rules-for-SonarQube/pull/242 to try and address this. There are a few more Maven changes due to incompatibilities between the current configuration in our POM and the new version of the packaging plugin. I'll try and have a stab at those later this week.

dbrin commented 1 day ago

Any update on this?