Add all spell events to ClosureEvents

[WareditorGit]

It would be useful to have all those events in ClosureEvents: EVENT_PLAYER_UNIT_SPELL_CHANNEL EVENT_PLAYER_UNIT_SPELL_CAST EVENT_PLAYER_UNIT_SPELL_EFFECT EVENT_PLAYER_UNIT_SPELL_FINISH EVENT_PLAYER_UNIT_SPELL_ENDCAST

Issue is that onCast is used for the EVENT_PLAYER_UNIT_SPELL_EFFECT event so we would have to find different names. After a conversation with @Frotty we came up with (in order): onChannel, onStart, onCast, onFinish and onEnd. Would be nice to have some feedback/suggestions before doing the PR.

[Donach]

@Krypt0n What about pushing BetterCast here?

[Krypt0n]

Ok so we have some enhanced casting System here, called "BetterCast" which handles several closure events, while using a preset ability (based on channel) which does mostly nothing but handling cooldown and manacost check. Current usable events:

OnBegin        
OnFail         
OnPreCast      
OnCastStart    
OnCastUpdate   
OnCastTick     
OnCastEnd      
OnEffect       
OnChannelStart 
OnChannelUpdate
OnChannelTick  
OnChannelEnd   
OnEnd          

Could do some adaptions and hotdoc, and might prepare it for stdlib, would need some polishing as well I guess. Still want to do some mayor improvements, thanks to PTR1.31, and also wanna make it triggerable with CustomUI. It has some Castbar/Channelbar, which should then also be updated to new frame functions.

//edit: Bettercast also features "Pushback" and "Interrupt" events.

[WareditorGit]

Using a preset ability for all those features might be out of the scope of a standard library or at least this package because it goes beyond the goals of ClosureEvents and makes backward compatibility tricky (though that's for @Frotty to decide). In my opinion, it should be included in a seperate package that is built using ClosureEvents.

[Krypt0n]

Well not for that issues I guess, more as some additional Util. Just reacted on my ping so far. But could take contribute the the PR, as i got some exp with that topic general.

[Frotty]

@Krypt0n ❓ 😄

[Krypt0n]

Yeah sup, well I was planning to reworked the system, and the thing is scale it a bit higher and that is not dooable by plain wc3 natives. So it will no run with my Custom UI API which is also WIP, and that is way to much for stdlib tbh.

So I won't pass it. But If still wanted @WareditorGit I can put my BetterCast code which uses native abilities somewhere so it can be used as basis.

[Frotty]

Yeah sup, well I was planning to reworked the system, and the thing is scale it a bit higher and that is not dooable by plain wc3 natives.

What?

[Krypt0n]

As I said. Its not done, and I pause that, cause working now on a Custom UI API, which will be required for the CastingSystem as it does fit all requirements with using, normal wc3 native abilities and triggers.

[Frotty]

I don't see how UI is related to adding spell events

[Donach]

Everything...

[Krypt0n]

Its basically the essence, cause without custom UI you can no clearing trigger spells that nicely and freely without interacting with units orders etc.

[Frotty]

Everything...

No. And then as @Krypt0n already said, this isn't stdlib material. This ticket is simply about adding spell events,

[Cokemonkey11]

@WareditorGit is this still valid?

[Frotty]

yes