search

wurstscript / WurstStdlib2

WurstScript Standard Library Version 2
Apache License 2.0
55 stars 53 forks source link

Prettify ChunkedString and FileIO #330

Closed rhazarian closed 4 years ago

rhazarian commented 4 years ago

Encapsulation, memory leaks and useless actions fixed.

Frotty commented 4 years ago

Looks good, but I'm not a big fan of the breaking getter changes.

rhazarian commented 4 years ago

I can remove it if you want. Though I think that it may be a good moment to change it now, because I guess none have used it a lot (if used at all) yet (since the package was added not a long time ago), and now the implementation is exposed and it blocks possible future changes. What's more, using the field to iterate over the string by indexes you had to iterate to the value inclusively, while usually you iterate to the size - 1, and that may confuse people aswell

Frotty commented 4 years ago

Thanks 👍 Make sure to update your other PR please.