wwivbbs / wwiv

WWIV BBS Software v5
http://www.wwivbbs.org
Other
186 stars 71 forks source link

numeric subtype for wwivnet sub reverts to subtype 0 #108

Closed wwiv closed 9 years ago

wwiv commented 9 years ago

Build:1432 Operating System:Linux

What Happened: When adding a new WWIVnet sub with a numeric subtype, the subtype is not getting set properly and it reverts to subtype 0 and thinks the sub is local.

What was expected: using a numeric subtype should work the same as an alpha subtype

Can you provide a screenshot?

Note that subtype is missing

(Q=Quit) Which (A-O,[=Prev,]=Next) : J

What sub type? 1
Will you be hosting the sub? No

Which system (number) is the host? 1

Attempt automated add request? Yes

Automated add request sent to @1

A) Name       : numeric subtype bug example
B) Filename   : broken
C) Key        : None.
D) Read SL    : 10
E) Post SL    : 20
F) Anony      : No
G) Min. Age   : 0
H) Max Msgs   : 50
I) AR         : None.
J) Net info   :
      Network      Type    Host    Scrb   Flags
   a) WWIVnet              1
K) Storage typ: 2
L) Val network: No
M) Req ANSI   : No
N) Disable tag: No
O) Description: None.

(Q=Quit) Which (A-O,[=Prev,]=Next) :
```~

Note that subtype is "0" not "1" 

```~
NN   AR Name                                  FN       RSL PSL AG MSGS  SUBTYPE
==== == ------------------------------------- ======== --- === -- ===== -------
   0    General                               GENERAL  10  20  0  50
   1    WWIVNET Sysop Area                    WWIVSYS  255 255 0  1000        0
   2    *TEST* Sysop                          1        255 255 0  1000        0
   3    GENCHAT                               GENCHAT  10  20  0  1000  GENCHAT
   4    numeric subtype bug example           broken   10  20  0  50          0
```~

It's hard to say that this is an issue with all numeric subtypes since there is only  one in the entire environment, which makes testing other numbers tough.  That said, it might be a good time to drop numeric subtypes and go with all alphanumeric.  There's really no reason not to.

Original comment by: granitepenguin
wwiv commented 9 years ago

If you set the net info, and do NOT auto-request to subscribe, the sub sets up properly. If you attempt to auto-add, the type gets borked.

Original comment by: granitepenguin

wwiv commented 9 years ago

Original comment by: wwiv

wwiv commented 9 years ago

Fixed in r1439

Original comment by: wwiv