wx.lib.agw.scrolledthumbnail.Thumb: Allow arbitrary thumb sizes

wxWidgets / Phoenix

wxPython's Project Phoenix. A new implementation of wxPython, better, stronger, faster than he was before.

http://wxpython.org/

2.29k stars 516 forks source link

wx.lib.agw.scrolledthumbnail.Thumb: Allow arbitrary thumb sizes #2191

Open wf-r opened 2 years ago

wf-r commented 2 years ago

Is there any reason that the Thumb size is by hard-coding restricted to at most (350, 280) without any error message/logging/warning? https://github.com/wxWidgets/Phoenix/blob/7d45ee6abbbc284f34d2ff018c464b65774f4ff3/wx/lib/agw/scrolledthumbnail.py#L1159-L1160

I see no obvious reason for this :)

infinity77 commented 2 years ago

No specific reason. Very many years ago it seemed like an ok idea, but there shouldn’t be any specific limitations per se - except for the speed at which the thumbnails are generated. I think Robin will be happy to accept sensible PRs