search

wxWidgets / Phoenix

wxPython's Project Phoenix. A new implementation of wxPython, better, stronger, faster than he was before.
http://wxpython.org/
2.34k stars 516 forks source link

DeprecationWarning due to distutils #2603

Closed komoto48g closed 2 months ago

komoto48g commented 2 months ago

Fixes #2577

Seems no DeprecationWarning due to distutils for now.

swt2c commented 2 months ago

Thanks for the PR! One thing - setuptools.modified was introduced somewhat recently. Should we either:

  1. try importing setuptools.modified and fall back to distutils if ImportError
  2. Update our setuptools requirement to ensure we have the version with setuptools.modified

I would lean towards #1 because it would enable us to support more setuptools versions.

komoto48g commented 2 months ago

Sorry for the late reply. Following the instruction 1, I modified the import statements.

By the way, #1 is mistakenly linked to the very first PR.