wxWidgets / wxWidgets

Cross-Platform C++ GUI Library

https://www.wxwidgets.org/

6.2k stars 1.78k forks source link

Auto (_)UNICODE in setup.h #6382

Closed wxtrac closed 2 years ago

wxtrac commented 20 years ago

Issue migrated from trac ticket # 6382

component: wxMSW | priority: normal

2003-12-18 14:42:57: g00fy (Steven Van Ingelgem) created the issue

The MSW setup has ANSII & UNICODE builds, but if you enabled wxUSE_UNICODE, then ALL those builds are in UNICODE.

This small patch is to enable UNICODE only in the specified compilations (and enable unicows-UNICODE at the same time).

wxtrac commented 20 years ago

2003-12-18 15:17:58: @vslavik commented

You didn't attach anything. This is already supposed to be the case on CVS HEAD, are you talking about 2.4 or the HEAD (except maybe the Unicows part, I don't know what you mean without seeing the patch)?

wxtrac commented 20 years ago

2003-12-18 21:39:45: g00fy (Steven Van Ingelgem) commented

Sorry, this file seems to have disappeared between my computer at work and sourceforge...

The change was for the 2.4.2 version:

ifndef wxUSE_UNICODE

if defined(_UNICODE) || defined(UNICODE)

#define wxUSE_UNICODE 1

else

#define wxUSE_UNICODE 0

endif

define IF_UNICODE_ENABLED__USE_MSLU 1

if defined(_UNICODE) || defined(UNICODE)

define wxUSE_UNICODE_MSLU

IF_UNICODE_ENABLED__USE_MSLU

else

define wxUSE_UNICODE_MSLU 0

endif

undef IF_UNICODE_ENABLED__USE_MSLU

wxtrac commented 20 years ago

2004-02-07 15:21:51: @vadz commented

Sorry but I don't wantto apply the patch because I think it's too dangerous to change anything like this for 2.4, after all this behaviour is well-known there and people may have their own workarounds in place for it which could be broken by this change. It's not a fatal error neither so I feel safer by not touching it in 2.4.

Thanks for your understanding!