search

wxt9861 / esxi_stats

ESXi component for Home Assistant
MIT License
145 stars 40 forks source link

disable HA notifications #64

Closed pathia closed 7 months ago

pathia commented 2 years ago

Is your feature request related to a problem? Please describe. It gets kinda annoying that every time I power on a machine I get a notification in HA.

Describe the solution you'd like Get an option to disable the notifications in HA for the service call to power on/off a machine.

Describe alternatives you've considered ?

Additional context

wxt9861 commented 2 years ago

Available in 0.7beta2 After changing the setting reload integration or restart home assistant

pathia commented 2 years ago

Awesome, thanks!

pathia commented 2 years ago

I tested it. It seems there's only a small glitch after updating. At first the integration was unable to start and in the logs it stated something about an unknown key notify. Unfortunately I forgot to copy the error. I'm sorry for that.

After disabling the notification I got rid of the error. And after enabling it again it didn't come back again. I think perhaps there is no initialization of the new variable notify?

DieMetRik commented 2 years ago

Error setting up entry host_name for esxi_stats Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 327, in async_setup result = await component.async_setup_entry(hass, self) File "/config/custom_components/esxi_stats/init.py", line 139, in async_setup_entry async_add_services(hass, config_entry) File "/config/custom_components/esxi_stats/init.py", line 298, in async_add_services notify = config_entry.options["notify"] KeyError: 'notify'

This error after update to 0.7 beta2

After disable checkbox "Create service call notifications" in ESXi Stats integration setting and reboot all good. And turned the flag back on.

wxt9861 commented 1 year ago

The error above should now be addressed in 0.7.0beta7