search

wysiib / linter-languagetool

Integration of Languagetool into the Atom text editor.
MIT License
17 stars 5 forks source link

add a way to ignore specific words like names and code snippets #29

Open thatkookooguy opened 6 years ago

thatkookooguy commented 6 years ago

When writing a document and adding code snippets or names, linter-languagetool marks those as lint errors.

so, for example, if I'm writing a markdown file, I can get an error on this text:

## gerrit
you can assign code reviewers on gerrit by going to `gerrit-owners-autoassign`

the name gerrit is a small probelm since I can always write it in Title case. The problem is with the code snippet. I can't set the linter-languagetool to ignore text wrapped in something or add words to the ignore list

tell me if you have plans on implementing this (or if you want me to send you a pull request for this feature)

wysiib commented 6 years ago

We have plans to implement this (would be quite useful for me aswell). However, I do not have much time on my hands right now. A pull request would certainly speed things up and is much appreciated. If you need any help let me know!

hesstobi commented 6 years ago

I already started to implement the Linter-Spell-Api (#23), which should resolve the problem with code snippets. The current implementation is working but needs to be improved. However, I also don't have time to work on that right now.

wysiib commented 6 years ago

I believe relying on something like discussed in #23 is the way to go. Futhermore, it solves multiple issues at once. So how much work do you think is left to do? Maybe you can push it to a feature branch and we all try to finish it together?

hesstobi commented 6 years ago

I start to implement to splitting of the document in ranges. But I didn't get it working properly. But I can push the current state to the repo. Maybe my code there needs a complete rewrite.

thatkookooguy commented 6 years ago

@wysiib I'll try and look for solutions, starting with @hesstobi code as a basis if it will make the job easier

hesstobi commented 6 years ago

Found this in the changelog: https://github.com/languagetool-org/languagetool/blob/master/languagetool-standalone/CHANGES.md#http-api--lt-server. This is maybe a way to go.

wysiib commented 6 years ago

That seems to be the way to go. What to interprete as markup and what to interpret as text could be extracted from Atoms grammar definitions. I think we might be able to get a "splitted" version of the editor content, as is done i.e. for highlighting code.

Wabuo commented 3 years ago

What's happening on this front?

Can I somehow help?

wysiib commented 3 years ago

I haven't heard anything from @hesstobi in a while. Thus, I suppose the issue is up to grab ;-) We have discussed several approaches that would lead to a solution for several use cases. In particular, I'd still advocate using something along the lines of the LinterSpell Api.

However, I am not actively using LinterSpell or LanguageTool at the moment and might have missed on certain news.