search

x42 / xjadeo

X JAck viDEo mOnitor: a tool that displays a video clip in sync with an external time source (jack-transport, LTC and MTC). Applications include: soundtrack composition/editing, video monitoring and -installations.
http://xjadeo.sf.net/
GNU General Public License v2.0
42 stars 7 forks source link

automake fails with sourceforce release tarball #59

Open umlaeute opened 2 weeks ago

umlaeute commented 2 weeks ago
  1. visit https://github.com/x42/xjadeo
  2. notice that it links to the "official" homepage http://xjadeo.sf.net/
  3. on the sf page go to downloads
  4. scroll down to get the download to the source tarball http://sourceforge.net/projects/xjadeo/files/xjadeo/v0.8.14/xjadeo-0.8.14.tar.gz/download
  5. download it
  6. extract the sources
  7. run autoreconf -fiv
$ autoreconf -fiv
[...]
configure.ac:443: error: required file 'src/qt-gui/Makefile.in' not found
configure.ac:443: error: required file 'src/qt-gui/qjadeo.pro.in' not found
[...]

(I'm running autoreconf, as the autogen.sh mentioned in the README is missing from the source tarball)

The problem is obviously, that the source tarball has no src/qt-gui/ folder.

I see that there is such a folder in this repository, but it has been stripped from the release tarball.

x42 commented 2 weeks ago

That is odd. looks like you've used enable_qtgui in the past. That setting is disabled by default, so autoreconf should not reach that code.

umlaeute commented 2 weeks ago

That is odd. looks like you've used enable_qtgui in the past.

??? this is from a fresh clone. (also i typically build 3rd party code in throw-away containers, so ...)

That setting is disabled by default, so autoreconf should not reach that code.

note that i'm talking about autoreconf (resp. automake which is what is called under the hood). as such, all the m4-code protecting https://github.com/x42/xjadeo/blob/c79144b882639e4dbe2a21a29d5570ea1a42b8ac/configure.ac#L443 with https://github.com/x42/xjadeo/blob/c79144b882639e4dbe2a21a29d5570ea1a42b8ac/configure.ac#L411 is rather pointless - as this code is never executed (it will get executed when running ./configure; but right now we are not there yet).

but i guess that https://github.com/x42/xjadeo/commit/ead81da39aab8cffffa7747584996ae0e1cab2a3 fixes it anyhow :-)

x42 commented 2 weeks ago

Do you need a new release, or can you pick the fix from git?

umlaeute commented 2 weeks ago

No it's fine. I've switched my scripts to now use the tagged archives from GitHub, rather than the source tarballs from SourceForge and reimported.