"Expected value to be greater than or equal to 1" in Accessor.set_Count

xBimTeam / XbimGltf

Export IFC geometry to gltf and related data to json

Other

85 stars 29 forks source link

"Expected value to be greater than or equal to 1" in Accessor.set_Count #15

Open oiurew opened 3 years ago

oiurew commented 3 years ago

Hi, I got this error when try to convert ifc file to gltf format.dont know if this is ifc file problem?

Exception.StackTrace:

glTFLoader.Schema.Accessor.set_Count(Int32 value)
Xbim.GLTF.Builder.AddIndices(List`1 indices)
Xbim.GLTF.Builder.AddGeom(List`1 positions, List`1 indices, List`1 normals)

WallStandardCase.zip

Thank you.

RespectableRuessel commented 3 years ago

Hi,

if you're still interested: I have tested your IFC on my fork of the GLTF converter dn9090/XbimGltf and it works there. I fixed a couple of issues with the old one, so hopefully it works for you too.

CBenghi commented 3 years ago

Hi @RespectableRuessel,

That's awesome!

If you put together a PR I'd be happy to review and merge.

Thanks, Claudio

RespectableRuessel commented 3 years ago

Hi @CBenghi,

I would love to create a pull request but my fork differs a lot from the original implementation see #17 . If you're fine with that we can merge both together but before that I would like to implement the hierarchy feature so that I'm confident that everything my company needs is working.

Thanks!

oiurew commented 3 years ago

thanks @RespectableRuessel it worked. thanks for your help. :D