Models not found in log when starting XL

[Darzoom]

NOTE: IF YOU DO NOT ATTACH A SEQUENCE THAT DEMONSTRATES YOUR PROBLEM THEN THERE IS A HIGH PROBABILITY YOUR ISSUE WILL JUST BE CLOSED AND NOT INVESTIGATED.

Describe the bug This is a multi part bug.

1. When starting XL first time the log indicates the models can't be found.
2. When opening a previously completed sequence the timing marks are missing.
3. When creating a new sequence and adding timing marks, saving the file, closing the sequence and reopening, the timing marks are missing.

To Reproduce Steps to reproduce the behavior: (and/or link to a short video showing the problem with audio track describing what you are doing)

1. Launce XL and see if the models are found in the logs.
2. Create a new sequence and add timing (beats) .
3. Save the sequence.
4. CLose the sequence
5. Reopen the sequence and the timing marks are missing.

Expected behavior A clear and concise description of what you expected to happen and why.

Versions (please complete the following information):

• OS: [Mac Monterey 12.6.4]
• xLights version - Occured in both 2023.4 and 2023.5.1

Attachments

Issue.zip xLightsProblem.zip xLights_dbgrpt-9782-20230402T192146.zip

[dkulp]

The timing marks "missing" is due to da4a98faecdb6a35fd01f5c36064fbea8db72fcd (and thus has been this way since 2022.24). For some reason, your timing marks are 0 length which is why they aren't being loaded. How are you creating them that they are 0 length? We likely need to make sure in the UI that effects cannot be shrunk down to 0 length as well.

[Darzoom]

I am creating the timing marks with Queen Mary Vamp using beats and onsets and tried with multiple settings with the same results.

On Apr 2, 2023, at 8:41 PM, Daniel Kulp @.***> wrote:

The timing marks "missing" is due to da4a98f https://github.com/smeighan/xLights/commit/da4a98faecdb6a35fd01f5c36064fbea8db72fcd (and thus has been this way since 2022.24). For some reason, your timing marks are 0 length which is why they aren't being loaded. How are you creating them that they are 0 length? We likely need to make sure in the UI that effects cannot be shrunk down to 0 length as well.

— Reply to this email directly, view it on GitHub https://github.com/smeighan/xLights/issues/3771#issuecomment-1493489461, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATP2FZFVRS5YRPP2ZIUBLY3W7IMDVANCNFSM6AAAAAAWQTUJP4. You are receiving this because you authored the thread.

[Darzoom]

What about the warning of the missing models?

On Apr 2, 2023, at 8:41 PM, Daniel Kulp @.***> wrote:

The timing marks "missing" is due to da4a98f https://github.com/smeighan/xLights/commit/da4a98faecdb6a35fd01f5c36064fbea8db72fcd (and thus has been this way since 2022.24). For some reason, your timing marks are 0 length which is why they aren't being loaded. How are you creating them that they are 0 length? We likely need to make sure in the UI that effects cannot be shrunk down to 0 length as well.

— Reply to this email directly, view it on GitHub https://github.com/smeighan/xLights/issues/3771#issuecomment-1493489461, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATP2FZFVRS5YRPP2ZIUBLY3W7IMDVANCNFSM6AAAAAAWQTUJP4. You are receiving this because you authored the thread.

[dkulp]

I cannot reproduce this at all. If I create a musical sequence and use the QM plugins to create timing tracks, I get proper timing tracks. You may want to re-install the QM plugins to make sure you have the latest version.

[Darzoom]

Something strange is Beats_4 and beats counts do. Not get erased and they were created with QM at the same time as the others.

On Apr 3, 2023, at 9:14 AM, Daniel Kulp @.***> wrote:

I cannot reproduce this at all. If I create a musical sequence and use the QM plugins to create timing tracks, I get proper timing tracks. You may want to re-install the QM plugins to make sure you have the latest version. https://user-images.githubusercontent.com/91569/229519831-070fb105-9bb1-4b87-8a9b-10fa63c1f7ef.png — Reply to this email directly, view it on GitHub https://github.com/smeighan/xLights/issues/3771#issuecomment-1494305043, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATP2FZFEVK5OCSENNAHOO6DW7LEJRANCNFSM6AAAAAAWQTUJP4. You are receiving this because you authored the thread.

[Darzoom]

I reinstalled QM and same result.

On Apr 3, 2023, at 9:14 AM, Daniel Kulp @.***> wrote:

I cannot reproduce this at all. If I create a musical sequence and use the QM plugins to create timing tracks, I get proper timing tracks. You may want to re-install the QM plugins to make sure you have the latest version. https://user-images.githubusercontent.com/91569/229519831-070fb105-9bb1-4b87-8a9b-10fa63c1f7ef.png — Reply to this email directly, view it on GitHub https://github.com/smeighan/xLights/issues/3771#issuecomment-1494305043, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATP2FZFEVK5OCSENNAHOO6DW7LEJRANCNFSM6AAAAAAWQTUJP4. You are receiving this because you authored the thread.

[computergeek1507]

I cannot reproduce this at all. If I create a musical sequence and use the QM plugins to create timing tracks, I get proper timing tracks. You may want to re-install the QM plugins to make sure you have the latest version.

Are you running from the sandbox?

[Darzoom]

I don’t believe I am. I can make a video clip of what I am doing or open a zoom session and show you.

On Apr 3, 2023, at 10:31 AM, Scott Hanson @.***> wrote:

I cannot reproduce this at all. If I create a musical sequence and use the QM plugins to create timing tracks, I get proper timing tracks. You may want to re-install the QM plugins to make sure you have the latest version. https://user-images.githubusercontent.com/91569/229519831-070fb105-9bb1-4b87-8a9b-10fa63c1f7ef.png Are you running from the sandbox?

— Reply to this email directly, view it on GitHub https://github.com/smeighan/xLights/issues/3771#issuecomment-1494438300, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATP2FZGKXKHGXS4A24CF2GDW7LNNZANCNFSM6AAAAAAWQTUJP4. You are receiving this because you authored the thread.

[AzGilrock]

I don’t believe I am. I can make a video clip of what I am doing or open a zoom session and show you. … On Apr 3, 2023, at 10:31 AM, Scott Hanson @.***> wrote: I cannot reproduce this at all. If I create a musical sequence and use the QM plugins to create timing tracks, I get proper timing tracks. You may want to re-install the QM plugins to make sure you have the latest version. https://user-images.githubusercontent.com/91569/229519831-070fb105-9bb1-4b87-8a9b-10fa63c1f7ef.png Are you running from the sandbox? — Reply to this email directly, view it on GitHub <#3771 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATP2FZGKXKHGXS4A24CF2GDW7LNNZANCNFSM6AAAAAAWQTUJP4. You are receiving this because you authored the thread.

Scott quoted Dan's reply so not sure he was asking you.

[Darzoom]

I've found it will create "proper" timing tracks when not using QMV plugins. This worked fine up to 2023.03. Since then it's no bueno. Seems any QMV with Audio detection feature of QMV. When opening an old sequence (from 2022) it will also break the timing tracks that previously existed. I have reloaded QMV ver 18 and no change.

[Darzoom]

How can the Aubio (Advance version of QMV) timing makes be made to work?

[derwin12]

These timing marks come from using the Advanced Queen Mary plugin - as noted these were valid until the change done v24. So now we have sequences that will no longer work going forward. Can this be reverted or perhaps changed to allow the 0 length timing marks?

https://github.com/smeighan/xLights/commit/da4a98faecdb6a35fd01f5c36064fbea8db72fcd

[derwin12]

Is it case of adding this if condition here?

[keithsw1111]

Timing tracks should never have zero length or overlapping timing marks. Our QM code previously allowed it and it shouldnt have. Deleting them is the right thing to do as they cause other issues. That said the underlying problem has not been addressed but I have pushed a fix which will handle such plugins I hope better ensuring that most of the desired marks are present while at the same time ensuring the timing track follows the rules. There are still some gap scenarios with the worst of the plugins (of which polyphonic transcription is one). If you want to use that one I suggest you instead import notes as it uses a slightly different approach which does even better at preserving all marks. That said the approach I implemented seems to handle most scenarios pretty well without the complexity of the note import code. For those with offending timing tracks you are going to have to delete and re-add the timing track using the new code to hopefully restore most of the behaviour.

[Darzoom]

Thanks Keith!

On Apr 24, 2023, at 4:35 PM, Daryl @.***> wrote:

These timing marks come from using the Advanced Queen Mary plugin - as noted these were valid until the change done v24. So now we have sequences that will no longer work going forward. Can this be reverted or perhaps changed to allow the 0 length timing marks?

da4a98f https://github.com/smeighan/xLights/commit/da4a98faecdb6a35fd01f5c36064fbea8db72fcd https://user-images.githubusercontent.com/4643499/234110500-f62e8383-0ed0-43cf-b4d3-f1a387d8d869.png — Reply to this email directly, view it on GitHub https://github.com/smeighan/xLights/issues/3771#issuecomment-1520792233, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATP2FZE7J575R2DFFT72WRDXC3PYPANCNFSM6AAAAAAWQTUJP4. You are receiving this because you authored the thread.

[derwin12]

Confirmed working .. just needed to redo the QM plugin add timing track process to recreate valid timing marks.

[Darzoom]

Yes it is working as expected and am reworking all previous sequences. Thanks again!

On Apr 25, 2023, at 1:55 PM, Daryl @.***> wrote:

Confirmed working .. just needed to redo the QM plugin add timing track process to recreate valid timing marks.

— Reply to this email directly, view it on GitHub https://github.com/smeighan/xLights/issues/3771#issuecomment-1522188554, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATP2FZHHNX6N3L4ABDYJOVTXDAFX7ANCNFSM6AAAAAAWQTUJP4. You are receiving this because you authored the thread.