xTVaser / src-twitch-ext

An Extension for Twitch.tv to Display a Runner's Personal Bests
https://www.twitch.tv/ext/u2nvainvlx73h5a7cnxpiodpfcbmo1
GNU General Public License v3.0
10 stars 4 forks source link

Separate Font options for WR time and have it actually work #48

Closed xwmtp closed 6 years ago

xwmtp commented 6 years ago

This is a...

Brief Description

I would like the option to change the color of the wr times (yellow by default).

(If Feature Request) Describe it.

I love how customizable the panel is in general. The only color that cannot be changed seems to be that of the wr times (except for the rainbow cycling option). Please tell me if I have overlooked it. Personally I like to customize the panel to a certain minimalistic style, and yellow does not seem to fit.

xTVaser commented 6 years ago

Hey!

I'm pretty sure that this option is supposed to change both the WR and PB time's color/font, but atm it seems to only effect the PBs. image

Seems like I broke it because changing the font affects both, but the color only changes the PB time. They should be separated anyway in my opinion.

This brings up a bigger issue in my mind and that is that the configuration page is imo very unnecessarily cluttered and I have a few ideas for how I can make it a lot better so I'll do both at the same time. I mostly was focused on getting the actual panel on the profile working and being fully-featured as it is obviously more important, now that that is mostly done I can work on the configuration side of things again.

Thanks for bringing this to my attention, if you have any other suggestions, feel free to let me know.

xTVaser commented 6 years ago

Separate options added, shifting to parent issue #57 to make sure all configuration settings work (these included)