search

xXSparkeyy / harbour-spritradar

4 stars 7 forks source link

Invalid zip code #16

Closed Pohli closed 5 years ago

Pohli commented 6 years ago

I often get the error message "Invalid zip code" after typing a German 5digit zip code into the search field and then after two or more tries it suddenly works and presents me results. Besides that it's a very useful app, thank you!

xXSparkeyy commented 6 years ago

Thanks! I can't reproduce the bug right now, but I will take a look at it when i finished my exams.

Armadill0 commented 6 years ago

I can confirm that issue. It happens quite frequently, but not always. Had no time for further debugging. Maybe I can have a look into this the next days.

The error itself is being displayed instant, so a timeout can be excluded.

Pohli commented 6 years ago

I forgot to mention that sometimes, after I got the error message and returned back to the search field, the app has replaced my entered zip code with an American address containing 5 digits codes, too. But this doesn't happen every time when I get the Invalid zip code message, only in some cases.

hoehnp commented 5 years ago

I can confirm that the issue still exists. I suspect the problem is that from my knowledge the google service to determine the geo coordinates has been shut down. I submitted a PR which resolves this. However, the variable address still needs to be split into a variable for the street and a variable for the city.

clausmichele commented 5 years ago

With the italian database is telling me "Invalid zip code"