Closed maxwestrom closed 5 months ago
xahlee
commented
5 months ago oh, sorry didn't see that. i just commited new, and was currently rewriting the whole xah-smart-delete. could you wait for a day and check out the new code for me? because it's big rewrite.
xahlee
commented
5 months ago i think i fixed the errors your caught about xah smart delete. and also fixed the outdated available layouts in readme, and the xah-goto-matching-bracket moving to prefix char. thank you.
maxwestrom
commented
5 months ago Hi Xah! Good that this code is all neat and tidy now. I tried it in elisp and sh-mode, and have only one nitpick: When deleting only brackets on a closing bracket, the point jumps to the start of the bracketed text. I think it should stay at the end of the text like it did earlier:
(goto-char (- xp0 2))Have a good one!
Prevent xah-goto-matching-bracket from going to prefix characters.
When deleting with C-u on an opening bracket, push mark so the bracketed text can be selected afterwards (same as on a closing bracket).
Fix a bug where deleting without C-u on a closing bracket in sh-mode might fail when deleting prefix characters due to mark-sexp behaving differently. Deleting without C-u on a closing bracket no longer pushes mark (same as on an opening bracket).
Make C-u on a closing bracket go to the end of the bracketed text correctly, even when deleting prefix characters.
Update available keymap values in the README.
With some luck, all bracket deletion behaviors should be good now. Cheers!