search

xamarin / Xamarin.Forms

Xamarin.Forms is no longer supported. Migrate your apps to .NET MAUI.
https://aka.ms/xamarin-upgrade
Other
5.63k stars 1.88k forks source link

[Bug] A wrong item is highlighted in the Shell menu on UWP #14160

Open holecekp opened 3 years ago

holecekp commented 3 years ago

Description

If you set the manually which item should be selected in the Shell menu, the UWP version behaves really weirdly. Usually it works well. But sometimes it opens the correct page but it highlight a wrong item in the shell menu as selected. It will be more clear if you look at the screenshot or if you try the repro project.

I am setting the page that should be opened in the Shell constructor in the repro project:

        public AppShell()
        {
           // ...
           CurrentItem = flyoutPage7;
        }

In reality, my application remembers the currently opened page when the application is closed, and tries to open the same page when the application is launched again. However, for the repro project, I am just opening Page 7 for simplicity. The problem depends on the page selected. Selecting Page 1 works (and correct item is highlighted in the menu) while selecting Page 7 and a few others does not work.

Steps to Reproduce

  1. Download the repro project and run it. It should open "Page 7" on startup.
  2. The page 7 is opened. But if you open the shell menu, page 3 is highlighted as opened instead.

Expected Behavior

Page 7 should be opened in the window. If the user opens the shell menu, Page 7 should be highlighted as opened (there should be a blue line next to Page 7 item.

Actual Behavior

Page 7 is opened in the window. However, if the user opens the shell menu, Page 3 is highlighted as opened (there is a blue line next to it).

Basic Information

Environment

Show/Hide Visual Studio info ``` Microsoft Visual Studio Community 2019 Version 16.9.4 VisualStudio.16.Release/16.9.4+31205.134 Microsoft .NET Framework Version 4.8.04084 Installed Version: Community Visual C++ 2019 00435-60000-00000-AA088 Microsoft Visual C++ 2019 ASP.NET and Web Tools 2019 16.9.693.2781 ASP.NET and Web Tools 2019 ASP.NET Core Razor Language Services 16.1.0.2112521+5741df381174d72f08e3632bb99f52e8635b6a1a Provides languages services for ASP.NET Core Razor. ASP.NET Web Frameworks and Tools 2019 16.9.693.2781 For additional information, visit https://www.asp.net/ Azure App Service Tools v3.0.0 16.9.693.2781 Azure App Service Tools v3.0.0 Azure Functions and Web Jobs Tools 16.9.693.2781 Azure Functions and Web Jobs Tools C# Tools 3.9.0-6.21160.10+59eedc33d35754759994155ea2f4e1012a9951e3 C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used. Common Azure Tools 1.10 Provides common services for use by Azure Mobile Services and Microsoft Azure Tools. Extensibility Message Bus 1.2.6 (master@34d6af2) Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration. IntelliCode Extension 1.0 IntelliCode Visual Studio Extension Detailed Info Microsoft Azure Tools 2.9 Microsoft Azure Tools for Microsoft Visual Studio 2019 - v2.9.40331.1 Microsoft Continuous Delivery Tools for Visual Studio 0.4 Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE. Microsoft JVM Debugger 1.0 Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines Microsoft Library Manager 2.1.113+g422d40002e.RR Install client-side libraries easily to any web project Microsoft MI-Based Debugger 1.0 Provides support for connecting Visual Studio to MI compatible debuggers Microsoft Visual C++ Wizards 1.0 Microsoft Visual C++ Wizards Microsoft Visual Studio Tools for Containers 1.1 Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container. Microsoft Visual Studio VC Package 1.0 Microsoft Visual Studio VC Package Mono Debugging for Visual Studio 16.9.7 (df23ba6) Support for debugging Mono processes with Visual Studio. NuGet Package Manager 5.9.0 NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/ ProjectServicesPackage Extension 1.0 ProjectServicesPackage Visual Studio Extension Detailed Info SQL Server Data Tools 16.0.62103.10080 Microsoft SQL Server Data Tools TypeScript Tools 16.0.30201.2001 TypeScript Tools for Microsoft Visual Studio Visual Basic Tools 3.9.0-6.21160.10+59eedc33d35754759994155ea2f4e1012a9951e3 Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used. Visual F# Tools 16.9.0-beta.21102.9+7ce7132f1459095e635194d09d6f73265352029a Microsoft Visual F# Tools Visual Studio Code Debug Adapter Host Package 1.0 Interop layer for hosting Visual Studio Code debug adapters in Visual Studio Visual Studio Container Tools Extensions 1.0 View, manage, and diagnose containers within Visual Studio. Visual Studio Tools for Containers 1.0 Visual Studio Tools for Containers VisualStudio.DeviceLog 1.0 Information about my package VisualStudio.Foo 1.0 Information about my package VisualStudio.Mac 1.0 Mac Extension for Visual Studio Xamarin 16.9.000.273 (d16-9@1bba9e0) Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android. Xamarin Designer 16.9.0.318 (remotes/origin/7b35adcdd1b204bbdcb279e0f029d151a20a4bf3@7b35adcdd) Visual Studio extension to enable Xamarin Designer tools in Visual Studio. Xamarin Templates 16.9.72 (426ebf6) Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms. Xamarin.Android SDK 11.2.2.1 (d16-9/877f572) Xamarin.Android Reference Assemblies and MSBuild support. Mono: 5e9cb6d Java.Interop: xamarin/java.interop/d16-9@54f8c24 ProGuard: Guardsquare/proguard/v7.0.1@912d149 SQLite: xamarin/sqlite/3.34.1@daff8f4 Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-9@d210f11 Xamarin.iOS and Xamarin.Mac SDK 14.14.2.5 (3836759d4) Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support. ```

Screenshots

Page 7 is opened (text on the right-hand side) but Page 3 is highlighted in the Shell menu (on the left-hand side) BadShellItemSelected

Reproduction Link

XamarinRepro-BadShellSelectionInUwp.zip

rachelkang commented 3 years ago

Hi, @holecekp - thanks for sharing! Confirming I'm able to repro the issue If possible, would you be able to share a sample of the working version on the older version of XF? I tried running your solution on an older version but unfortunately had some trouble building

holecekp commented 3 years ago

@rachelkang It should be suffitient to downgrade Xamarin.Forms Nuget to 4.8, clean the solution and delete all obj and bin folders in it. The last step is important. Cleaning the solution probabably does not clean everything, and I could also see a change only after I had deleted obj and bin folders.