search

xamarin / Xamarin.Forms

Xamarin.Forms is no longer supported. Migrate your apps to .NET MAUI.
https://aka.ms/xamarin-upgrade
Other
5.64k stars 1.88k forks source link

[Bug] #15326

Open brennani opened 2 years ago

brennani commented 2 years ago

Description

DataTrigger conditional StringFormat may be bugged for ContentPage or members it inherits.

See attached link for full explanation: https://stackoverflow.com/questions/71962796/how-to-set-the-contentpage-title-stringformat-through-boolean-binding-in-xamarin

Expected Behavior

The binding would conditionally apply a string format

Actual Behavior

The binding on the forms show an empty value

Basic Information

Environment

Show/Hide Visual Studio info ``` Microsoft Visual Studio Community 2019 Version 16.11.11 VisualStudio.16.Release/16.11.11+32228.343 Microsoft .NET Framework Version 4.8.04084 Installed Version: Community ASP.NET and Web Tools 2019 16.11.106.23128 ASP.NET and Web Tools 2019 ASP.NET Web Frameworks and Tools 2019 16.11.106.23128 For additional information, visit https://www.asp.net/ Azure App Service Tools v3.0.0 16.11.106.23128 Azure App Service Tools v3.0.0 Azure Functions and Web Jobs Tools 16.11.106.23128 Azure Functions and Web Jobs Tools C# Tools 3.11.0-4.22108.8+d9bef045c4362fbcab27ef35daec4e95c8ff47e1 C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used. Common Azure Tools 1.10 Provides common services for use by Azure Mobile Services and Microsoft Azure Tools. Extensibility Message Bus 1.2.6 (master@34d6af2) Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration. IntelliCode Extension 1.0 IntelliCode Visual Studio Extension Detailed Info JustDecompilePackage2017 Extension 1.0 JustDecompilePackage2017 Visual Studio Extension Detailed Info Microsoft Azure Tools for Visual Studio 2.9 Support for Azure Cloud Services projects Microsoft Continuous Delivery Tools for Visual Studio 0.4 Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE. Microsoft JVM Debugger 1.0 Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines Microsoft Library Manager 2.1.113+g422d40002e.RR Install client-side libraries easily to any web project Microsoft MI-Based Debugger 1.0 Provides support for connecting Visual Studio to MI compatible debuggers Microsoft Visual Studio Tools for Containers 1.2 Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container. Mono Debugging for Visual Studio 16.10.15 (552afdf) Support for debugging Mono processes with Visual Studio. NuGet Package Manager 5.11.0 NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/ ProjectServicesPackage Extension 1.0 ProjectServicesPackage Visual Studio Extension Detailed Info Razor (ASP.NET Core) 16.1.0.2122504+13c05c96ea6bdbe550bd88b0bf6cdddf8cde1725 Provides languages services for ASP.NET Core Razor. SQL Server Data Tools 16.0.62201.17150 Microsoft SQL Server Data Tools TypeScript Tools 16.0.30526.2002 TypeScript Tools for Microsoft Visual Studio Visual Basic Tools 3.11.0-4.22108.8+d9bef045c4362fbcab27ef35daec4e95c8ff47e1 Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used. Visual F# Tools 16.11.0-beta.21514.6+b6c2c4f53ea3a08fa603ea93d6d2f808a62a21d1 Microsoft Visual F# Tools Visual Studio Code Debug Adapter Host Package 1.0 Interop layer for hosting Visual Studio Code debug adapters in Visual Studio Visual Studio Container Tools Extensions 1.0 View, manage, and diagnose containers within Visual Studio. Visual Studio Tools for Containers 1.0 Visual Studio Tools for Containers VisualStudio.DeviceLog 1.0 Information about my package VisualStudio.Foo 1.0 Information about my package VisualStudio.Mac 1.0 Mac Extension for Visual Studio Xamarin 16.11.000.197 (d16-11@6934992) Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android. Xamarin Designer 16.11.0.47 (remotes/origin/d16-11@e0d612363) Visual Studio extension to enable Xamarin Designer tools in Visual Studio. Xamarin Templates 16.10.5 (355b57a) Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms. Xamarin.Android SDK 12.0.0.3 (d16-11/f0e3c2d) Xamarin.Android Reference Assemblies and MSBuild support. Mono: c633fe9 Java.Interop: xamarin/java.interop/d16-11@476bb5b ProGuard: Guardsquare/proguard/v7.0.1@912d149 SQLite: xamarin/sqlite/3.35.4@85460d3 Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-11@87af37b Xamarin.iOS and Xamarin.Mac SDK 15.2.0.17 (738fde344) Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support. ```

Screenshots

See attached link: https://stackoverflow.com/questions/71962796/how-to-set-the-contentpage-title-stringformat-through-boolean-binding-in-xamarin

Reproduction Link

https://stackoverflow.com/questions/71962796/how-to-set-the-contentpage-title-stringformat-through-boolean-binding-in-xamarin

Workaround

Stated in attached link, reversing the condition trigger so that the default binding does not have the StringFormat gets it to work. (* Note, this works for the example, but there are other projects I have where changing the order does not resolve the issue) See the EDIT in the attached link: https://stackoverflow.com/questions/71962796/how-to-set-the-contentpage-title-stringformat-through-boolean-binding-in-xamarin

jfversluis commented 2 years ago

I see you're mentioning an older version of Xamarin.Forms, please check if this is still happening in the latest stable version.

brennani commented 2 years ago

Upgraded to Xamarin.Forms (5.0.0.2401) and Xamarin.Essentials (1.7.2) and still witnessing the issue. The older versions of Xamarin happened to be because that is what is deployed in the default project. I upgraded the project from the example and still witness it. My other projects were already at the current version and experience it.

brennani commented 2 years ago

I've added additional information to the stackoverflow post. Adding an additional DataTrigger to cover the other boolean case seemingly causes the binding to get stuck after a bit, no longer updating. From my understanding, I should be able to have a default value in the original Title binding, and then a DataTrigger for when my boolean is True and a DataTrigger for when my boolean is False and they should be able to toggle between them, but it seems like the triggers may only fire so many times. Perhaps it's due to being a boolean value?

brennani commented 2 years ago

I've further added additional information regarding my testing the DataTrigger with string values. It seems some of the evaluations may be off. In my example, the DataTrigger below is being applied when the Text is equal to multiple values that are not "test2" (e.g. I tried "test3" and it applied the "test2" Setter. Again, the stackoverflow post has additional screen captures to show what I mean.

<DataTrigger TargetType="ContentPage" Binding="{Binding Source={x:Reference testSwitchString}, Path=Text}" Value="test2">
            <Setter Property="Title" Value="{Binding Title, StringFormat='{0} SWITCHED'}"/>
</DataTrigger>