search

xarray-contrib / xarray-regrid

Regridding utility for xarray
https://xarray-regrid.readthedocs.org/
Apache License 2.0
71 stars 7 forks source link

Keep attributes after conservative regridding #26

Closed kjdoore closed 9 months ago

kjdoore commented 9 months ago

When regridding a data set using the conservative method, all attributes from the original xarray object are lost. It would be nice if those attributes could remain attached to the regridded data set like the linear method.

BSchilperoort commented 9 months ago

Hi Keith, thanks for opening this issue! I hope that the package has been useful for you. I have added tests for this, and fixed the issue in #27.

Would you be willing/able to review the PR? Then I'll mark you as reviewer. If you're unsure about this that OK.

kjdoore commented 9 months ago

Hi Bart, thanks for updating this so quickly! I would be happy to review the PR for you.

I have a project that I am working on that currently uses xESMF, but I am trying to switch away from it due to its large dependencies and the preference of using xarray add-ons vs specific packages. I have another issue related to the handling of NaNs that I have noticed, which I will bring up as new issues.

BSchilperoort commented 9 months ago

I have added you as a collaborator, if you could leave a review that'd be great.

The heaviness of xESMF and other packages is exactly why I started this package. And of course ESMF is not available on e.g. Windows which was a downside we encountered in other projects.

Any other issues would be very welcome, that'd really help with improving this package.