search

xbikuna / nettopologysuite

Automatically exported from code.google.com/p/nettopologysuite
0 stars 0 forks source link

NTS as PortableFramework setup - Serialization #183

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Both GeoAPI and NetTopologySuite have some classes that are marked with the  
[Serializable] attribute.

As that is not present in the portable class library subset, we have made some 
effort and added [DataContract]/[DataMember] attributes to ensure an equivalent 
functionality.

I'm wondering if we could do without and leave all serialization responsibility 
to the clients of this library.

The reasons I don't really want it are that 
- I don't use the serialization,
- I am not aware that anyone uses it,
- I don't like the output of the serialization

Original issue reported on code.google.com by felix.ob...@netcologne.de on 15 May 2014 at 7:05

GoogleCodeExporter commented 8 years ago

Original comment by felix.ob...@netcologne.de on 15 May 2014 at 7:06

GoogleCodeExporter commented 8 years ago 
I'm not sure how to fix this issue.
You're asking:
> I don't use the serialization,
Me too
> I am not aware that anyone uses it
Maybe someone at Geodan uses it or think it's useful?
> I don't like the output of the serialization
It's really an issue?

What do you mean for
>leave all serialization responsibility to the clients of this library
there is a way to make serializable a class not marked as serializable?

Original comment by diegogu...@gmail.com on 5 Jun 2014 at 6:55

GoogleCodeExporter commented 8 years ago 
>> I don't like the output of the serialization
> It's really an issue?
If it is out, it is out. We can change it now or stick with it

Original comment by felix.ob...@netcologne.de on 5 Jun 2014 at 10:00

GoogleCodeExporter commented 8 years ago 
>we can change it now or stick with it
absolutely.
what about removing serialization with a compilation directive also for 
standard build, and then make a new release?
with this, we can think about this issue.

Original comment by diegogu...@gmail.com on 10 Jun 2014 at 12:17

GoogleCodeExporter commented 8 years ago 
I had a chat with john diss, and he manifested my impression that it is not 
worth it to provide DataContract/DataMember for the PCL classes.

John Diss:
<quote>
I have always hated .net serialization :)
all the stuff assciated with web services was slow and sucky
personally I would rather have a set of classes responsible for serializing to 
a given format
</quote>

The previous Silverlight, WindowsPhone and Monodroid versions of NTS lived 
without serialization, the PCL will too.

Anyone willing to help, remove the DataContract/DataMember attributes from the 
codebase and the associated conditionals. thanks

Original comment by felix.ob...@netcologne.de on 27 Jun 2014 at 8:27

GoogleCodeExporter commented 8 years ago 
>Anyone willing to help, remove the DataContract/DataMember attributes 
>from the codebase and the associated conditionals. thanks
+1, I can do it easily now

Original comment by diegogu...@gmail.com on 27 Jun 2014 at 9:48

GoogleCodeExporter commented 8 years ago 
or, even better, soon :)

Original comment by diegogu...@gmail.com on 27 Jun 2014 at 9:55

GoogleCodeExporter commented 8 years ago 
removed "stuff" for PCL build only with r1240

Original comment by diegogu...@gmail.com on 27 Jun 2014 at 10:45

GoogleCodeExporter commented 8 years ago 
thanks diego!

Original comment by felix.ob...@netcologne.de on 1 Jul 2014 at 8:27