This PR delivers a major rework of SettingsValuesViewController. Main motivation was to set the label dimensions matching the text which needs to be displayed instead of hardcoding the dimensions or scaling down font sizes. While implementing this several other updates were obvious to be made ad well:
Aligning colors of slider, scrubbingView and footerView with App colors
Aligning font sizes with library view
Enlarged fonts for descriptions
Rework creation and layout of footerView (only create once)
Remove magic numbers
Coding styles
Remove obsolete or commented code
Screenshots (top = new, bottom = before):
Summary for release notes
Maintenance: Internal rework of SettingsViewController for better maintenance
Improvement: Automatically choose correct sizes for setting labels
Improvement: Place toggle switch next to setting name and not its description
Improvement: Better readability by larger fonts for setting description
Improvement: Remove "[CR]", BB and html code from descriptions
Improvement: Align scrubbingView, footer and slider colors with App colors
Description
Closes https://github.com/xbmc/Official-Kodi-Remote-iOS/issues/509. Yay! :)
This PR delivers a major rework of
SettingsValuesViewController. Main motivation was to set the label dimensions matching the text which needs to be displayed instead of hardcoding the dimensions or scaling down font sizes. While implementing this several other updates were obvious to be made ad well:slider,scrubbingViewandfooterViewwith App colorsfooterView(only create once)Screenshots (top = new, bottom = before):
Summary for release notes
Maintenance: Internal rework of SettingsViewController for better maintenance Improvement: Automatically choose correct sizes for setting labels Improvement: Place toggle switch next to setting name and not its description Improvement: Better readability by larger fonts for setting description Improvement: Remove "[CR]", BB and html code from descriptions Improvement: Align scrubbingView, footer and slider colors with App colors