search

xbmc / Official-Kodi-Remote-iOS

Full-featured remote control for XBMC Media Center. It features library browsing, now playing informations and a direct remote control.
Other
224 stars 104 forks source link

Bugfix: Fix memory leak when calculating average color #1158

Closed wutschel closed 1 month ago

wutschel commented 1 month ago

Description

This PR fixes a memory leak in averageColor:inverse:autoColorCheck: where rawImageRef was created but never released. This caused a massive memory leak in the use case of TV or Radio channel lists in grid view.

Summary for release notes

Bugfix: Fix memory leak when calculating average color

wutschel commented 1 month ago

@kambala-decapitator, this is a nasty one. I found this while testing for the effectiveness of the in-memory limitation of the image cache. But I really need someone to review this change. Testing looks fine though so far.

wutschel commented 1 month ago

Fixed the NULL pointer check and reindented whole method.