search

xbmc / xbmc

Kodi is an award-winning free and open source home theater/media center software and entertainment hub for digital media. With its beautiful interface and powerful skinning engine, it's available for Android, BSD, Linux, macOS, iOS, tvOS and Windows.
https://kodi.tv/
Other
18.23k stars 6.28k forks source link

.edl scene marker action is invalid #25591

Closed rayes0 closed 1 month ago

rayes0 commented 1 month ago

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:

Specifying 2 as the action for an .edl file does not work in kodi, however it is listed as supported according to the wiki entry (https://kodi.wiki/view/Edit_decision_list#MPlayer_EDL)

Expected Behavior

Here is a clear and concise description of what was expected to happen:

The line should be parsed as valid and a chapter should be created with a new scene marker upon playback.

Actual Behavior

The line parses as invalid.

Possible Fix

To Reproduce

Steps to reproduce the behavior:

Testing with an edl file containing the following:

46.67 129.96 2

The file has no effect, and gives the following error in the log:

warning <general>: ReadEdl - Invalid action on line 1 in EDL file: [REDACTED].edl

However, the rest of the actions work fine:

46.67 129.96 0 <-- works
46.67 129.96 1 <-- works
46.67 129.96 3 <-- works

Debuglog

The debuglog can be found here:

warning <general>: ReadEdl - Invalid action on line 1 in EDL file: [REDACTED].edl

Screenshots

Here are some links or screenshots to help explain the problem:

n/a

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Your Environment

Used Operating system:

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required. Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

xbmc-gh-bot[bot] commented 1 month ago

Thank you for using Kodi and our issue tracker. This is your friendly Kodi GitHub bot :wink:

It seems that you have not followed the template we provide and require for all bug reports (or have opened a roadmap item by accident). Please understand that following the template is mandatory and required for the team to be able handle the volume of open issues efficiently.

Please edit your issue message to follow our template and make sure to fill in all fields appropriately. The issue will be closed after one week has passed without satisfactory follow-up from your side.

This is an automatically generated message. If you believe it was sent in error, please say so and a team member will remove the "Ignored rules" label.

KarellenX commented 1 month ago

I am unable to replicate the problem.

I have tried: 46.67 129.96 2 (your timestamps) 129.96 2 1200.00 2 00:20:00.00 2

All 4 methods worked for me.

debug <general>: CEdl::ReadEditDecisionLists - Checking for edit decision lists (EDL) on local drive or remote share for: F:\HTPC Movies from TV\A Time to Kill (1996)\A Time to Kill (1996).mkv
debug <general>: CEdl::AddSceneMarker - Inserting new scene marker: 00:02:09.960
debug <general>: CEdl::ReadEdl - Read 0 edits and 1 scene markers in EDL file: F:\HTPC Movies from TV\A Time to Kill (1996)\A Time to Kill (1996).edl

Line 911... https://paste.kodi.tv/mefelenamo.kodi

rayes0 commented 1 month ago

My apologies, it seems I got confused from my debug log that the specific edl file was causing problems, but the problem was actually from another edl file which was indeed invalid for a different reason. Just tested it and it does work fine, sorry for the extraneous confusion.

KarellenX commented 1 month ago

No problems. Glad it is working. :)